Re: master b72f885: Make dlet work like let, not let*

[Eli Zaretskii]

> branch: master
> commit b72f88518b89560accf740a4548368863e6238e0
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
> 
>     Make dlet work like let, not let*
>     
>     Change `dlet` so that it has binding semantics like `let` because that
>     is what a user would expect and it allows a corresponding `dlet*` to
>     be added later should the need arise.  Fortunately the change has no
>     effect where it is currently used.
>     
>     * lisp/subr.el (dlet): Work like let.
>     * lisp/calendar/cal-bahai.el (calendar-bahai-date-string):
>     * lisp/calendar/cal-coptic.el (calendar-coptic-date-string):
>     * lisp/calendar/cal-dst.el (calendar-time-zone-daylight-rules)
>     (calendar-dst-starts, dst-in-effect):
>     * lisp/calendar/cal-persia.el (calendar-persian-date-string):
>     * lisp/calendar/calendar.el (calendar-dlet, calendar-generate-month)
>     (calendar-update-mode-line, calendar-date-string):
>     * lisp/calendar/diary-lib.el (diary-list-entries-2)
>     (diary-list-entries, diary-mark-entries-1, diary-sexp-entry)
>     (diary-remind, diary-font-lock-date-forms, diary-fancy-date-pattern):
>     * lisp/calendar/holidays.el (holiday-sexp):
>     * lisp/calendar/icalendar.el (icalendar--convert-float-to-ical):
>     * lisp/calendar/solar.el (solar-time-string):
>     * lisp/calendar/todo-mode.el (todo-date-pattern)
>     (todo-edit-item--header, todo-convert-legacy-date-time)
>     (todo-read-date):
>     Rename `calendar-dlet*` to `calendar-dlet` since it uses `dlet`.

Why is this change a good idea?  We had 'dlet' since more than a year
ago, so the ship has sailed quite some time ago, I'd say.