emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Merging the pgtk branch


From: Stefan Monnier
Subject: Re: Merging the pgtk branch
Date: Sun, 01 Aug 2021 12:57:15 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>>> @@ -165,9 +168,9 @@ gui--selection-value-internal
>>>  Call `gui-get-selection' with an appropriate DATA-TYPE argument
>>>  decided by `x-select-request-type'.  The return value is already
>>>  decoded.  If `gui-get-selection' signals an error, return nil."
>>> -  (let ((request-type (if (eq window-system 'x)
>>> +  (let ((request-type (if (memq window-system '(x pgtk))
>>>                            (or x-select-request-type
>>> -                              '(UTF8_STRING COMPOUND_TEXT STRING))
>>> +                              '(UTF8_STRING COMPOUND_TEXT STRING 
>>> text/plain\;charset=utf-8))
>>>                          'STRING))
>> 
>> Is it useful to have "text/plain\;charset=utf-8" here when
>> window-system is 'x', not 'pgtk'?
>
> I think no.  But the combination is not harmful.

What is the intended difference between `UTF8_STRING`
and `text/plain\;charset=utf-8`?

>>> +  ;; Don't let Emacs suspend under PGTK.
>>> +  (add-hook 'suspend-hook 'pgtk-suspend-error)
>> What's this about?  If PGTK doesn't want to be suspended, why do this
>> via a hook?
> If you try to suspend PGTK emacs via emacs running on a terminal (-nw),
> the try will be rejected.

Indeed, `grep suspend-hook` shows that all GUIs have this.
We should consolidate this.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]