Re: master 1f24519 1/2: Allow storing SMTP variables when queueing mail

[Robert Pluim]

>>>>> On Thu, 12 Aug 2021 14:49:49 +0200, Lars Ingebrigtsen <larsi@gnus.org> 
>>>>> said:

    Lars> Robert Pluim <rpluim@gmail.com> writes:
    Lars> -     (let* ((smtpmail-smtp-server (nth 1 method))
    Lars> +     (let* ((smtpmail-store-queue-variables t)
    Lars> +               (smtpmail-smtp-server (nth 1 method))
    Lars> (service (nth 2 method))
    Lars> (port (string-to-number service))
    Lars> ;; If we're talking to the TLS SMTP port, then force a
    >> 
    >> Why is smtpmail-store-queue-variables unconditionally bound to t here?
    >> The user might be queuing mail, but not want to store the variables, no?

    Lars> In this case, the data is from the X-Message-SMTP-Method header.  If 
the
    Lars> user has used such a header, and is queuing the mail, then the user 
does
    Lars> want to store the variables. 

Iʼd say 'probably', but Iʼll admit that the percentage of people who
donʼt want that is pretty small.

Robert
--