Re: Native compiler - passing command line options to C compiler

[Arthur Miller]

Andrea Corallo <akrl@sdf.org> writes:

> Arthur Miller <arthur.miller@live.com> writes:
>
>> Hi again,
>>
>> after the few mails the other day, I wasn't really sure if Andrea is going to
>> implement it and when.
>
> Sure I was going to implent it as I said so, but thanks for taking the
> task :)

I just wanted to test it myself, and it looked like an easy thing to do so it
felt like I can do it, so you have time to do something more important, like
grab a beer, get on a date, or implement some more optimizations? :-)

>> I thought it was rather a tedious manual labour and maybe
>> not so important, so I took me a liberty to implement this myself in my own, 
>> so
>> called, personal copy of Eamcs sources.
>>
>> I am not sure if I have done it correctly though, I appreciate if Andrea have
>> time to take a look;
>
> I just have a small suggestion.
>
>> Mark set
>>
>> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
>> index 80a1da5ad8..58d361cf46 100644
>> --- a/lisp/emacs-lisp/comp.el
>> +++ b/lisp/emacs-lisp/comp.el
>> @@ -166,6 +166,16 @@ native-comp-async-query-on-exit
>>    :type 'boolean
>>    :version "28.1")
>>  
>> +(defcustom native-comp-compiler-options nil
>> +  "Options passed verbatim to the native compiler's c driver.
>
> I'd just say "passed to the compiler" or "passed to GCC" as there's no C
> involed.

Yes, I'll change it. I didn't know really what to say that to be honest.

>> +#endif
>> +  if (CONSP (options))
>> +    xsignal1 (Qnative_compiler_error,
>> +          build_string ("Customizing native compiler options"
>> +                        " via `comp-native-compiler-options' is"
>> +                        " only available on libgccjit version 9"
>> +                        " and above."));
>> +
>> +  /* Captured `comp-native-driver-options' because file-local.  */
>                     ^^^
>                   native-comp-compiler-options ?
>                     
No idea, but I can change it :-).

> Other that that the patch LGTM.  Could you provide it with its
> Changelog?

Yes, will do later tonight.

Do you want me to also rename the 'native-comp-driver-options' to
'native-comp-backend-options' when I am anyway at it? I can do it in the same
patch if you want.