emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Draw and scribble notes in GNU Emacs


From: Po Lu
Subject: Re: [Patch] Draw and scribble notes in GNU Emacs
Date: Thu, 09 Sep 2021 16:33:08 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Anand Tamariya <atamariya@gmail.com> writes:

> Code: https://gitlab.com/atamariya/emacs/-/blob/dev/lisp/svg.el

Good work, but it appears to be comprised solely of modifications to
svg.el.  Is there any particular reason it cannot be separated from the
rest of svg.el, which is geared towards programmatic creation of images,
as opposed to providing a paint program?

  . ;; ewp functions copied from 
https://github.com/larsmagne/ewp/blob/master/ewp.el
  . (defun ewp-crop-image (&optional square)
  . (defun ewp-crop-image-update (area data size type)
  . (defun ewp-crop-image-1 (svg &optional square image-width image-height)
  . (defun ewp-find-corner (area pos corners)
  . (defun ewp-content-type (image)
  . (defun ewp--image-type ()

It would be good to prefix the names of these functions with something
other than "ewp", because they could conflict with the functions present
in ewp.

Further, I don't believe ewp has undergone copyright assignment to the
FSF.  If the code is to be included in Emacs, that will likely have to
be solved first.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]