emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tab-line: New tab-line-tab-face-modified face


From: Adam Porter
Subject: Re: [PATCH] tab-line: New tab-line-tab-face-modified face
Date: Sat, 25 Sep 2021 19:14:49 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Juri Linkov <juri@linkov.net> writes:

>>> But why font-lock-doc-face?  Have you tried to change tab background color?
>>> I guess this would be more visually pleasing.  Or maybe not.  This needs
>>> more experimentation.
>>
>> Because in the default theme, it results in text that's a dark red,
>> which is easily distinguished against the default tab background color,
>> while still being readable (IMHO).  It reminds me of other editors I've
>> used that use the red color to indicate a modified tab, so I think it
>> should be somewhat familiar to users.  And by using a "font-lock-" face,
>> it will be themed automatically by common third-party themes; while that
>> doesn't guarantee it will look good with any theme by default, it should
>> help.
>
> Ah, this explains everything - a dark red makes sense, but long ago
> I customized this face to green and forgot that by default it's dark
> red :)

LOL, that's so easy to do.  :)

> Thanks for the patch, now applied.

Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]