[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PR: dired-do-create-files now checks for trailing slashes in the tar

From: Tassilo Horn
Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target
Date: Wed, 29 Sep 2021 17:17:35 +0200
User-agent: mu4e 1.7.0; emacs 28.0.50

Stefan Kangas <stefankangas@gmail.com> writes:

>> But it's nice functionality.  Is there some other way we could get
>> this without relying on the difference between foo and foo/?  A
>> separate command, perhaps?  Or some extra prompting?

Lars, note that we are not talking about a specific command like
`dired-do-rename'.  The change is to `dired-do-create-files' which is a
workhorse for many dired commands that need some target directory or
file, e.g., renaming/moving, copying, symlinking, etc.

> How about a prompt by default (e.g. "Do you want to create directory
> `foo' and move the file into it?"), with a user option to disable it
> for those that want it?

There already is `dired-create-destination-dirs'.  Only if that is
non-nil, Rudi's patch has an effect.  And if it is 'ask, you'll be
prompted if foo/ should be created already.

Of course, it won't explain the "move the marked/current file(s) into
it" part.  (Note that while we are talking about just a single source
file, it could be many.)

We could also let-bind `dired-create-destination-dirs' around the one
specific place Rudi touched so that it gets a special value
'ask-because-of-trailing-slash-in-target if it's non-nil already which
would allow `dired-maybe-create-dirs' to issue a more explanatory
message.  But then again, this could also happen with copying or
symlinking, so that message couldn't really say "move into" without
moving more context into down to `dired-maybe-create-dirs' so that it
can distinguish "move into" from "create a new symlink into" or what


reply via email to

[Prev in Thread] Current Thread [Next in Thread]