[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New tab-bar-detach-tab command

From: Juri Linkov
Subject: Re: [PATCH] New tab-bar-detach-tab command
Date: Wed, 29 Sep 2021 22:43:21 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> Looking at that command, I'm not sure how to change its interactive spec
> to move a tab to a new frame without changing the command's documented
> behavior.  But using it to do the work of moving a tab to a new frame
> created by another command is straightforward and easy for me to
> understand.  :)

You are right, the existing command can't be changed to make a new frame.

> I've attached a new patch for your consideration.  It seems to work
> correctly (correcting the issue Matt noted), and it also adds the new
> command to the tab bar context menu.  If you'd still prefer to change
> 'tab-bar-move-tab-to-frame' to accomodate this functionality, I'm not
> sure what you have in mind.

I confirm that the issue Matt noted is corrected by your patch.
So I pushed your patch (with a small correction of 0/1 indexing).
Thanks to you and to Matt.

Also I fixed another issue noted by Matt:
“tab-close: Attempt to delete the sole tab in a frame”.
This is fixed now to delete the whole frame when its last tab
was moved to another frame.

>>> It might be worth binding it to something like "C-x t D" as well,
>>> assuming the command is worth merging.  :)
>> Currently I'm developing a command that will detach a window
>> to a new tab, i.e. it will delete the selected window
>> from the current tab after moving it to the new tab.
>> And I'd like to add a keybinding to it with the same mnemonics "D" :-)
> Hm, what if the new window-detaching command were on "C-x t d", and the
> new tab-detaching command were on "C-x t D"?  Of course, "C-x t d" is
> currently bound to 'dired-other-tab', but it seems like that should be
> covered by 'other-tab-prefix', i.e. "C-x t t C-x d".

'C-x t d' was modeled after 'C-x 5 d' (dired-other-frame),
and since I use 'C-x t d' all the time, I expect that other users
might be accustomed to it as well.  We need to find a new key
or better a key prefix to accommodate more future keys.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]