Re: [PATCH] New tab-bar-detach-tab command

[Adam Porter]

Juri Linkov <juri@linkov.net> writes:

> I confirm that the issue Matt noted is corrected by your patch.
> So I pushed your patch (with a small correction of 0/1 indexing).
> Thanks to you and to Matt.

Thanks.

> Also I fixed another issue noted by Matt:
> “tab-close: Attempt to delete the sole tab in a frame”.
> This is fixed now to delete the whole frame when its last tab
> was moved to another frame.

Great!

>>>> It might be worth binding it to something like "C-x t D" as well,
>>>> assuming the command is worth merging.  :)
>>>
>>> Currently I'm developing a command that will detach a window
>>> to a new tab, i.e. it will delete the selected window
>>> from the current tab after moving it to the new tab.
>>> And I'd like to add a keybinding to it with the same mnemonics "D" :-)
>>
>> Hm, what if the new window-detaching command were on "C-x t d", and the
>> new tab-detaching command were on "C-x t D"?  Of course, "C-x t d" is
>> currently bound to 'dired-other-tab', but it seems like that should be
>> covered by 'other-tab-prefix', i.e. "C-x t t C-x d".
>
> 'C-x t d' was modeled after 'C-x 5 d' (dired-other-frame),
> and since I use 'C-x t d' all the time, I expect that other users
> might be accustomed to it as well.  We need to find a new key
> or better a key prefix to accommodate more future keys.

Makes sense.  Thanks.