[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Moving kbd to subr.el

From: T.V Raman
Subject: Re: Moving kbd to subr.el
Date: Wed, 13 Oct 2021 09:01:02 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Stefan Kangas <stefan@marxist.se> writes:

Yes, you'd  need to fix at least
that documented  incompatibility and likely others; it shows that
writing lots of tests for that function are really important.

If nothing else, rewriting it made the code (at least to me) readable;
the implementation from reading kbd macros was pretty well
incomprehensible at least to my reading of it.

> Stefan Kangas <stefan@marxist.se> writes:
>> Is your 'new-kbd' intended to be bug-for-bug compatible with 'kbd', or
>> have there been any functional changes along the way?  Are you
>> suggesting that we could perhaps just replace 'kbd' with your new
>> version?  (One observation is that your version still uses the cl-
>> functions, so it would need adjusting for subr.el.)
> Now I note the following comments:
> ;;; Tests:
> ;;; Note that we fail on
> ;;; "M-ESC"
> ;;; "M-<DEL>"
> ;;; "H-<RET>" etc,
> ;;; But match on "H-RET"
> ;;; (thanks Drew Adams) Likely due to over-optimization.
> So I guess we could borrow ideas from your code but not use it as a
> drop-in replacement in its current form.



--Raman(I Search, I Find, I Misplace, I Research)
?7?4 Id: kg:/m/0285kf1  ?0?8

reply via email to

[Prev in Thread] Current Thread [Next in Thread]