[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 859190f 2/3: Convert some keymaps to defvar-keymap

From: Stefan Monnier
Subject: Re: master 859190f 2/3: Convert some keymaps to defvar-keymap
Date: Thu, 14 Oct 2021 16:59:55 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> (define-key map [tab] 'todo-next-button)
> Hm, the kbd syntax would be
> (define-key map [TAB] 'todo-next-button)
> but I guess it's fine...

No, the `kbd` syntax for `tab` is "<tab>".

> (define-key function-key-map [C-delete] [?\M-d])
> That's C-<delete> in kbd syntax -- I guess it's fine if we accept both,
> but then we lose the opportunity to be stricter with the syntax.

I guess we could also accept `C-<delete>`, but I think it would be
better to catch it and signal an error.

> Oh, yeah, I had totally forgotten that this is how menus are defined.
> To it's ambiguous here -- the thing in [] could be anything, including
> [s], which kdb would interpret as the key "s".

This area of Emacs is tricky enough that we may encounter surprises, but
I think using [?s] for such a menu entry "key binding" would work just
fine, currently.

> This form is limited to menu items, though, so perhaps it could be made
> to work (i.e., if the DEF is a menu item, then we have different logic).

I'd rather not go there.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]