[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Do

From: Dmitry Gutov
Subject: Re: master f56408a: * lisp/progmodes/xref.el (xref-pop-marker-stack): Don't obsolete.
Date: Tue, 26 Oct 2021 12:35:41 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 26.10.2021 11:56, Mattias Engdegård wrote:
It felt small-minded to generate obsoletion warnings for external packages that 
now have to make their code uglier in order to avoid that if they are 
particulate about a clean CI, especially if they compile with 
byte-compile-error-on-warn (which I often do).

The warning doesn't tell them anything useful; the semantics haven't changed. 
This is in contrast to the variables made obsolete.

Does this reasoning make sense? I could revert the change.

I don't have a strong opinion about it, but that's how we usually do renames: without changing semantics, mark the previous name as obsolete.

I suppose the alternative is to wait for ~6 years until it's reasonable to drop support for Emacs 28 in third-party code? And then mark it obsolete?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]