[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Support for undo-amalgamate in a version of the atomic-change-group
From: |
Stefan Monnier |
Subject: |
Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch) |
Date: |
Sun, 07 Nov 2021 08:21:51 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> Here is an updated patch with a separate macro to amalgamate undo barriers.
Looks pretty good, thanks.
I was about to install it into `master` but noticed the following:
- You seem not to have signed copyright paperwork yet. If you're OK
with it, please fill the form below and send it to the FSF so they can
send you the relevant paperwork to sign.
[ The change is sufficiently small that we can accept it right away,
but since the paperwork process takes some time, it's good to do it
"in advance" so it's out of the way for your next contributions. ]
- I see the macro binds undo limits, but AFAICT this is an "accident"
resulting from copy&pasting code from the other macro: for the
atomic-change macro it's very important that undo info is not thrown
away since the macro uses the undo info internally to cancel changes
on error, but for this macro I can't see any harm in having the undo
info truncated, so I think we shouldn't change the undo limit
vars. WDYT?
Stefan
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Stefan Monnier, 2021/11/01
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Campbell Barton, 2021/11/01
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Stefan Monnier, 2021/11/01
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Campbell Barton, 2021/11/01
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Campbell Barton, 2021/11/07
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch),
Stefan Monnier <=
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Campbell Barton, 2021/11/07
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Campbell Barton, 2021/11/07
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Stefan Monnier, 2021/11/07
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Lars Ingebrigtsen, 2021/11/07
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Campbell Barton, 2021/11/08
- Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch), Stefan Monnier, 2021/11/08