[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: repeat-mode: Setting `repeat-map' property to a keymap object fails
From: |
Narendra Joshi |
Subject: |
Re: repeat-mode: Setting `repeat-map' property to a keymap object fails |
Date: |
Thu, 25 Nov 2021 19:09:42 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Juri Linkov <juri@linkov.net> writes:
>> I tried to use a `keymap' object as the value of the `repeat-map'
>> property of a symbol/command and it failed. I think the change below
>> would avoid the problem. The problem is that `boundp` throws an error
>> for anything other than a symbol value.
>>
>> diff --git a/lisp/repeat.el b/lisp/repeat.el
>> index 4dcd353e34..32ffb1884f 100644
>> --- a/lisp/repeat.el
>> +++ b/lisp/repeat.el
>> @@ -416,7 +416,7 @@ repeat-post-hook
>> (and (symbolp real-this-command)
>> (get real-this-command 'repeat-map)))))
>> (when rep-map
>> - (when (boundp rep-map)
>> + (when (and (symbolp rep-map) (boundp rep-map))
>> (setq rep-map (symbol-value rep-map)))
>> (let ((map (copy-keymap rep-map)))
>
> Thanks, fixed now.
>
Thanks. I see that it's merged to `emacs-28`. How/when would it end up
on the master branch? I am just curious about the overall process.
Best,
--
Narendra Joshi