emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 501e2096d6: Fix some issues with a recent change


From: Eli Zaretskii
Subject: Re: master 501e2096d6: Fix some issues with a recent change
Date: Mon, 27 Dec 2021 16:31:44 +0200

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: luangruo@yahoo.com,  emacs-devel@gnu.org
> Date: Sun, 26 Dec 2021 23:27:09 -0500
> 
> > Once again, personal workflows should not affect our coding
> > conventions.
> 
> AFAIK the conventions are designed to help the various workflows out
> there.

Some of them, but not all of them.

> Some parts of the convention will only be useful for some of
> those workflows, of course.  We do have a convention about the first
> line being a kind of summary, even though you seem not to care about
> that convention.

I do care about that, and try to follow it in my commits.  I just
don't think that file names necessarily belong to the summary.

> Why do we bother with such a first-line-convention if it doesn't even
> give any indication whatsoever about which part of the codebase
> is modified?

Because sometimes that's the best that can be said in a single short
line.  Or because the changes are so minor they don't deserver
anyone's attention on this high level.  Or for any number of other
reasons.

> A summary should say something non-trivial about the change.

What if the change doesn't have anything non-trivial?

And what's non-trivial for me might be trivial for you, or vice versa.

Coming up with that summary is already a kind of burden, in those
cases where there's no useful summary that can be so short.  You are
now requesting on top of that to provide information that is uniquely
interesting to you, because you filter the changes based on that.  I
think this is too much to expect, and I therefore respectively ask you
not to insist on this detail.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]