emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of


From: Robert Pluim
Subject: Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
Date: Tue, 04 Jan 2022 14:25:32 +0100

>>>>> On Tue, 28 Dec 2021 13:08:54 -0500 (EST), Eli Zaretskii <eliz@gnu.org> 
>>>>> said:

    Eli> branch: master
    Eli> commit 8276605efb09abf8f86dad56f5c43fa57e5c1bd7
    Eli> Author: Eli Zaretskii <eliz@gnu.org>
    Eli> Commit: Eli Zaretskii <eliz@gnu.org>

    Eli>     ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
    Eli> ---
    Eli>  lisp/keymap.el | 2 +-
    Eli>  1 file changed, 1 insertion(+), 1 deletion(-)

    Eli> diff --git a/lisp/keymap.el b/lisp/keymap.el
    Eli> index 734cbe89cd..25288013cf 100644
    Eli> --- a/lisp/keymap.el
    Eli> +++ b/lisp/keymap.el
    Eli> @@ -297,7 +297,7 @@ See `kbd' for a descripion of KEYS."
    Eli>  (defun key-valid-p (keys)
    Eli>    "Say whether KEYS is a valid key.
    Eli>  A key is a string consisting of one or more key strokes.
    Eli> -The key strokes are separated by a space character.
    Eli> +The key strokes are separated by space characters.

This is ambiguous now.

ELISP> (key-valid-p "a")
t
ELISP> (key-valid-p "a b")
t
ELISP> (key-valid-p "a  b")
nil

Either we say 'single spaces', or we set OMIT-NULLS to t in the call
to `split-string' inside `key-valid-p'.

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]