emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Incorrect font weight selected


From: Yuri D'Elia
Subject: Re: Incorrect font weight selected
Date: Thu, 06 Jan 2022 00:16:15 +0100
User-agent: mu4e 1.7.5; emacs 29.0.50

On Wed, Jan 05 2022, Eli Zaretskii wrote:
> When we look at low-level code such as this one, we should always keep
> that in mind, and avoid leaking the face definitions to other frames.
> The trick of making the change take effect on other frames is
> implemented by higher levels.

Do you have a more concrete overview of how the change _should_ at least
ideally be propagated for me to get a better overview?

One side-effect of pushing a few set-face-font calls in a
after-make-frame hook in my setup (as opposed to calling set-face-font
once) was a noticeable increase of time required to show the resulting
frame, which is not too nice to have.

> This is the general background that makes me uneasy to accept the
> changes which you suggested, because they seem to violate that general
> principle on a very low level.

In this sense, the change only fixes the lower-level font selection when
opening a face in a single frame, so it doesn't alter how we're
propagating the change at all at the moment.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]