emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [nongnu] main 823df3487e: * elpa-packages (pacmacs): New package


From: Stefan Kangas
Subject: Re: [nongnu] main 823df3487e: * elpa-packages (pacmacs): New package
Date: Sat, 8 Jan 2022 11:45:59 -0600

Philip Kaludercic <philipk@posteo.net> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> branch: main
>> commit 823df3487e89663484191ff5b23b327468efb683
>> Author: Stefan Kangas <stefan@marxist.se>
>> Commit: Stefan Kangas <stefan@marxist.se>
>>
>>     * elpa-packages (pacmacs): New package
>
> This package appears to depend on f.el.  The dependency or the package
> should be removed so that the package isn't marked as incompatible.

Ouch.

> It shouldn't be hard, if this quick grep is right:
>
> --8<---------------cut here---------------start------------->8---
> viero$ grep -r -F '(f-'
> tools/pacmacs-rr.el:  (-> (f-read-text filename)
> tools/compile.el:                                             (and (f-file? 
> path)
> tools/compile.el:                                                  (f-ext? 
> path "el"))))
> tools/att.el:  (f-write (format "Average Tick Time: %fms" 
> (pacmacs--average-tick-time))
> pacmacs-score.el:         (f-read-text)
> Binary file 
> .git/objects/pack/pack-f85e046b5df6f330c64cf410e834049e8504c417.pack matches
> pacmacs.el:  (let* ((lines (split-string (f-read-text map-file-name)
> --8<---------------cut here---------------end--------------->8---
>
> Ie. two invocations of f-read-text.

I'll look into it, thanks.

I find that dependencies on s.el and f.el are sometimes trivial to
remove, but in some cases their functions have subtly different behavior
from the built-in functions that makes it hard to be sure that you're
not introducing bugs in the process.  See e.g.
https://github.com/org-roam/org-roam/pull/2025



reply via email to

[Prev in Thread] Current Thread [Next in Thread]