Re: Time to merge scratch/correct-warning-pos into master, perhaps?

[Alan Mackenzie]

Hello, Lars.

On Sun, Jan 16, 2022 at 09:24:31 +0100, Lars Ingebrigtsen wrote:
> Eli Zaretskii <eliz@gnu.org> writes:

> >> So, I would propose to merge the branch into master now.  What do people
> >> (in particular Eli) say about this?

> > Fine with me if Lars agrees.

> I'm seeing one compilation warning on the branch:

> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)

I don't see this any more (though I've seen plenty of the like in the
past two or three weeks).  Was that build a bootstrap build?

> And a "time make -j8 bootstrap check" takes

> real  3m31.160s

> while it's

> real  3m16.761s

> on master.  A 7% slowdown is rather significant.

I suspect there is more conditional branching happening in the test
suite than in "normal" Lisp code.

Also, the bootstrap is doing more work - it is keeping track of source
positions for correct warning messages, something master doesn't do.

To keep things in perspective, solving the recent bug #53164 took about
the same amount off the build time.

The way to reduce the bootstrap time is surely to build
lisp/emacs-lisp/comp.el with a byte-compiled compiler rather than the
interpreted source one.  This latter takes about 2½ minutes on my
machine.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).