[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Sv: Sv: Support for background transparency
From: |
Robert Pluim |
Subject: |
Re: Sv: Sv: Support for background transparency |
Date: |
Mon, 24 Jan 2022 10:14:52 +0100 |
>>>>> On Sun, 23 Jan 2022 22:43:04 +0100, Håkon Flatval <hkon20@hotmail.com>
>>>>> said:
>> - Something answering the question: "what's the difference between
>> this and the existing 'alpha frame parameter",
Håkon> I added paragraph after that for alpha with a brief description.
Håkon> I have included it in the attached patch. For convenience, I'm
Håkon> reciting the relevant part here:
Håkon> ====
Håkon> diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi
Håkon> index 2eeb8b7ed7..05d0b1a72a 100644
Håkon> --- a/doc/lispref/frames.texi
Håkon> +++ b/doc/lispref/frames.texi
Håkon> @@ -2433,6 +2433,16 @@ Font and Color Parameters
Håkon> Some window systems do not support the @code{alpha} parameter
for child
Håkon> frames (@pxref{Child Frames}).
Håkon> +
Håkon> +@vindex alpha-background@r{, a frame parameter}
Håkon> +@item alpha-background
Håkon> +@cindex opacity, frame
Håkon> +@cindex transparency, frame
Håkon> +Sets the background transparency of the frame. Unlike the
@code{alpha}
Håkon> +frame parameter, this only controls the transparency of the
background
Håkon> +while keeping foreground elements such as text fully opaque.
Håkon> +It should be an integer between 0 and 100, where 0 means
Håkon> +completely transparent and 100 means completely opaque (default).
Håkon> @end table
Håkon> The following frame parameters are semi-obsolete in that they are
Håkon> ====
Håkon> Please let me know if this is what you had in mind or if I should
revise
Håkon> it.
That looks good, although the Emacs convention is to put two spaces
after '.'
>> - a commit message containing a description of the changes in
>> ChangeLog format
Håkon> I have attached a file with a changelog entry. I'm also giving it
here
Håkon> for convenience:
Håkon> ====
Håkon> 2022-01-23 Håkon Flatval <hkon20@hotmail.com>
Håkon> Add support for background transparency
Håkon> * src/haikufns.c:
Håkon> * src/nsfns.m:
Håkon> * src/pgtkfns.c:
Håkon> * src/w32fns.c:
Håkon> * src/xfns.c: Add alpha-background frame parameter defaults.
Prefer to use 32-bit depth visual in X.
Håkon> * src/frame.h:
Håkon> * src/frame.c: Add alpha-background frame parameter and setter
function.
Håkon> * src/gtkutil.c: Setup GTK to allow transparency.
Håkon> * src/xterm.c: Draw background transparent using
alpha-background frame parameter.
Håkon> * doc/lispref/frames.texi: Add docs for alpha-background frame
parameter
Håkon> ====
Håkon> Let me know if it needs changes.
Each filename should also have the name of the affected function in
parens after it (before the ':'). C-x 4 a when in a diff will fill in
this kind of stuff for you automatically (or
'magit-generate-changelog' if you use magit to commit).
Håkon> I'm a little confused as to where I should put this. Should I add it
to
Håkon> one of the Changelog files?
It goes in the commit message when you commit locally using git. See
CONTRIBUTE in the emacs repository (search for "** Commit messages")
Committing locally has the additional advantage that you can later do
"git format-patch" to produce a patch file, which is easy for the
maintainers to apply (and preserves your commit message and authorship
info).
Robert
--
- Re: Sv: Sv: Sv: Support for background transparency, (continued)
- Re: Sv: Sv: Sv: Support for background transparency, Po Lu, 2022/01/25
- Re: Sv: Sv: Sv: Support for background transparency, Robert Pluim, 2022/01/26
- Re: Sv: Sv: Sv: Support for background transparency, Håkon Flatval, 2022/01/26
- Re: Sv: Sv: Sv: Support for background transparency, Po Lu, 2022/01/26
- Re: Sv: Sv: Sv: Support for background transparency, Håkon Flatval, 2022/01/28
- Re: Sv: Sv: Sv: Support for background transparency, Po Lu, 2022/01/28
Re: Sv: Sv: Support for background transparency, Robert Pluim, 2022/01/20
- Re: Sv: Sv: Support for background transparency, Håkon Flatval, 2022/01/23
- Re: Sv: Sv: Support for background transparency,
Robert Pluim <=
- Re: Sv: Sv: Support for background transparency, Håkon Flatval, 2022/01/25
- Re: Sv: Sv: Support for background transparency, Robert Pluim, 2022/01/25
- Re: Sv: Sv: Support for background transparency, Po Lu, 2022/01/29
- Re: Sv: Sv: Support for background transparency, Håkon Flatval, 2022/01/29
- Re: Sv: Sv: Support for background transparency, Po Lu, 2022/01/29