[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add epub support to doc-view

From: Iñigo Serna
Subject: Re: [PATCH] add epub support to doc-view
Date: Thu, 27 Jan 2022 22:09:23 +0100
User-agent: mu4e 1.6.10; emacs 29.0.50


I'm afraid this chunk is missing from the commit, so opening epub or fb2
fails with this cryptic error message:

DocView: process pdf/ps->png changed status to exited abnormally with code 1.

@@ -1189,7 +1216,7 @@ doc-view-pdf/ps->png
  "Convert PDF-PS to PNG asynchronously."
   (pcase doc-view-doc-type
-     ('pdf doc-view-pdf->png-converter-function)
+ ((or 'pdf 'epub 'cbz 'fb2 'xps 'oxps) doc-view-pdf->png-converter-function)
     ('djvu #'doc-view-djvu->tiff-converter-ddjvu)
     (_ #'doc-view-ps->png-converter-ghostscript))
   pdf-ps png nil


On 27 January 2022 at 17:05 +01, Lars Ingebrigtsen <larsi@gnus.org> wrote:

dalanicolai <dalanicolai@gmail.com> writes:

Just a gentle reminder, because I am not sure if you have seen this. I think this patch is more or less ready for merging (all previous feedback
 has been processed, and it is only a small patch).

Thanks; pushed to Emacs 29 (with some changes -- there were
byte-compilation warnings due to the ordering of macros and variables).

And it's usually safer to submit patches with `M-x submit-emacs-patch'
so that the patches land in the bug tracker.  Patches posted to
emacs-devel have an unfortunate tendency to get lost.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]