[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 2c79a8f 2/2: Use posix_spawn if possible.
From: |
Saulius Menkevicius |
Subject: |
Re: master 2c79a8f 2/2: Use posix_spawn if possible. |
Date: |
Mon, 7 Feb 2022 23:12:27 +0200 |
Hello Robert, Eli,
I can confirm that this patch is needed for emacs-28 too, as currently emacs on
macOS blocks SIGCHLD the same way as it does on Linux.
Applying Robert’s patch on emacs-28 fixes the issue on macOS.
Tested on macOS 12.2 / aarch64.
-Saulius
> Am 2022-02-02 um 10:54 schrieb Saulius Menkevičius
> <sauliusmenkevicius@fastmail.com>:
>
> I’ve just received a new Mac (arm64/M1) for myself so I can test if 28 has it
> broken on macOS too.
>
> —Saulius Menkevičius
>
>> Am 2022-02-02 um 10:30 schrieb Robert Pluim <rpluim@gmail.com>:
>>
>>
>>>
>>>>>>> On Tue, 01 Feb 2022 21:52:18 +0200, Eli Zaretskii <eliz@gnu.org> said:
>>
>>>> From: Robert Pluim <rpluim@gmail.com>
>>>> Cc: Eli Zaretskii <eliz@gnu.org>, Matt Armstrong <matt@rfc20.org>,
>>>> p.stephani2@gmail.com, alan@idiocy.org, mituharu@math.s.chiba-u.ac.jp,
>>>> emacs-devel@gnu.org
>>>> Date: Tue, 01 Feb 2022 20:23:23 +0100
>>>>
>>>>>>>>> On Tue, 1 Feb 2022 20:30:18 +0200, Saulius Menkevicius
>>>>>>>>> <sauliusmenkevicius@fastmail.com> said:
>>>>
>> Saulius> Thanks Robert!
>> Saulius> I applied your patch and that has actually has fixed the issue.
>> So I
>> Saulius> suggest this patch be applied on master.
>>>>
>>>> I can do that, if Eli/Lars agree.
>>
>> Eli> Are there any downsides to the patch? If not, I see no reasons not to
>> Eli> install that.
>>
>> Not as far as I can tell, but I shall test on a few more platforms
>> before pushing.
>>
>>>> What should we do for emacs-28?
>>
>> Eli> Nothing, because on emacs-28 we use posix_spawn only on macOS.
>>
>> Right, Iʼd missed that, master it is then. We could put it in 28.2, I
>> guess, but I hadn't noticed any issues with subprocesses on emacs-28
>> on macOS.
>>
>> Robert
>> --
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Robert Pluim, 2022/02/01
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Saulius Menkevicius, 2022/02/01
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Robert Pluim, 2022/02/01
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Eli Zaretskii, 2022/02/01
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Robert Pluim, 2022/02/02
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Saulius Menkevičius, 2022/02/02
- Re: master 2c79a8f 2/2: Use posix_spawn if possible.,
Saulius Menkevicius <=
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Robert Pluim, 2022/02/08
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Eli Zaretskii, 2022/02/08
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Saulius Menkevicius, 2022/02/08
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Robert Pluim, 2022/02/08
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Saulius Menkevicius, 2022/02/08
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Robert Pluim, 2022/02/09
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Saulius Menkevicius, 2022/02/12
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Eli Zaretskii, 2022/02/12
- Re: master 2c79a8f 2/2: Use posix_spawn if possible., Saulius Menkevicius, 2022/02/12