[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 68e293c81d: Fix reporting of imaginary key prefixes on toolki
From: |
Po Lu |
Subject: |
Re: master 68e293c81d: Fix reporting of imaginary key prefixes on toolkit tool and menu bars |
Date: |
Wed, 02 Mar 2022 21:40:35 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Robert Pluim <rpluim@gmail.com> writes:
> If the only purpose of menu_bar_p and tool_bar_p is to set an
> appropriate value for posn, then would it not be simpler to have the
> hook return the desired value directly?
It would be simpler, but this is going to be used in some other places
as well (to fix toolbar clicks not working after a passive grab on an
xwidget is released on top, for example.)
> Also, Iʼd put the track_mouse if condition as the outer test, to avoid
> calling the hook when its value is not actually needed.
Sure thing, thanks. I assumed it would be clearer this way since the
comment on top describes that test as a temporary solution.