Re: [PATCH] Fix bookmark-bmenu-list sorting.

[Eli Zaretskii]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: kfogel@red-bean.com,  emacs-devel@gnu.org
> Date: Fri, 04 Mar 2022 16:15:51 +0100
> 
> > Or maybe you can show a simple recipe starting from "emacs -Q", then I
> > could see for myself what happened in Emacs 27 vs Emacs 28.
> 
> This would do:
> --8<---------------cut here---------------start------------->8---
> (defun dobook (name)
>   (with-current-buffer (get-buffer-create name)
>     (set-visited-file-name (format "/tmp/%s" name))
>     (bookmark-set (buffer-name))))
> 
> (progn
>   (dobook "a")
>   (dobook "b"))
> --8<---------------cut here---------------end--------------->8---
> 
> And then "M-x bookmark-bmenu-list". As bookmark "b" was the last
> defined, it should be at the top of the list… but I've just tested in
> Emacs 27.2 and the bookmark list was already alphabetically sorted. So I
> guess this is not a regression (and won't make it into 28 then).

OK, thanks.

One more question: your patch included this part:

> diff --git a/lisp/bookmark.el b/lisp/bookmark.el
> index 2751731817..80fb1cdfc7 100644
> --- a/lisp/bookmark.el
> +++ b/lisp/bookmark.el
> @@ -1819,7 +1819,7 @@ bookmark-bmenu--revert
>                         (list location))])
>                entries)))
>      (tabulated-list-init-header)
> -    (setq tabulated-list-entries entries))
> +    (setq tabulated-list-entries (reverse entries)))
>    (tabulated-list-print t))

Why is that needed?