[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#54245: 29.0.50; select usage in GNUstep
From: |
Eli Zaretskii |
Subject: |
Re: bug#54245: 29.0.50; select usage in GNUstep |
Date: |
Mon, 14 Mar 2022 15:10:09 +0200 |
> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 14 Mar 2022 10:22:13 +0100
> Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
>
> >>>>> On Sat, 05 Mar 2022 20:00:50 +0100, Lars Ingebrigtsen <larsi@gnus.org>
> >>>>> said:
>
> Lars> Robert Pluim <rpluim@gmail.com> writes:
> Po> That LGTM, but I only tested on GNUstep. The same code is also used
> on
> Po> macOS, so there might be some side effects.
> >>
> >> Iʼm on macOS
>
> Lars> Thanks; I've pushed Robert's patch to Emacs 29 now, and I'm
> therefore
> Lars> closing this bug report.
>
> I think this means we can now remove the checking for select in
> configure, and the HAVE_SELECT define (I took a look, but then ran
> into the w32 and msdos ports, and decided to stop :-) )
If that's your problem, you could convert HAVE_SELECT into DOS_NT, I
think.
The HAVE_SELECT in msdos.c is for the (old and quite defunct) MSDOS
build with Xlib (yes, there was such a beast: see those HAVE_X_WINDOWS
in msdos.c?), so IMNSHO we can simply drop HAVE_SELECT in msdos.c.