Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v"

[Lars Ingebrigtsen]

Sam Steingold <sds@gnu.org> writes:

> branch: master
> commit f52dcfd03ad542704d9a43faab0c33be09ab442e
> Author: Sam Steingold <sds@gnu.org>
> Commit: Sam Steingold <sds@gnu.org>
>
>     New command `gnus-summary-browse-all-urls' bound to "v"
>
>     * lisp/gnus-sum.el (gnus-collect-urls-from-article): New function,
>       extracted from `gnus-summary-browse-url'.
>     (gnus-summary-browse-url): Use it; also use `browse-url-button-open-url'
>       to handle the prefix argument.
>     (gnus-summary-browse-all-urls): New command.
>     (gnus-summary-mode-map): Bind `gnus-summary-browse-all-urls' to "v".

I've reverted this patch -- I did not agree that this command should be
added, so you should not have pushed it, Sam.

To reiterate -- I don't think this command sounds generally useful, and
furthermore, if it is, it should not be bound to such a convenient key
like `v', and moreover, the funky calling conventions of
`browse-url-button-open-url' should be avoided.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no