emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Select completions from the minibuffer


From: Ergus
Subject: Re: Select completions from the minibuffer
Date: Thu, 17 Mar 2022 19:47:01 +0100

On Mon, Mar 14, 2022 at 09:34:17PM +0200, Juri Linkov wrote:
Now there is a variable completions-highlight-face. When nil highlight
is disabled, otherwise it must be a the face to use, by default
completions-highlight.

I had the mode before because I needed some initialization, but with the
cursor-face feature that is not needed and the code got simpler.

Thanks, highlighting works correctly when the current buffer is *Completions*.
But cursor-face is not highlighted in *Completions* when the current buffer
is the minibuffer.  Such highlighting is necessary when completions
are navigated from the minibuffer.

Please check the change and try to set
cursor-face-highlight-nonselected-window unconditionally in
*Completions* to t when using your mode.

If you could improve the initialization in order to use
cursor-in-non-selected-windows unless the user sets another value
manually it may be nicer (because in the general scenario the user could
set cursor-in-non-selected-windows latter so this variable may have an
outdated value) otherwise consider if this may be simply t or nil by
default. But at the moment it works fine for the current use cases.

Best, Ergus


reply via email to

[Prev in Thread] Current Thread [Next in Thread]