[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs pretest 28.0.92 is out
From: |
Andrew Cohen |
Subject: |
Re: Emacs pretest 28.0.92 is out |
Date: |
Sun, 20 Mar 2022 14:04:23 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
>>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:
[...]
>> I do not know as how mature the third pretest is ranked.
>> Personally, I find bug 54158 very annoying; it is a regression
>> compared with Emacs 27. Please, let me know if there is anything
>> I can help debugging it. Unfortunately, it goes beyond my
>> expertise.
EZ> Eric, Lars, can we solve that bug soon, please?
Below is a patch that fixes this bug. Note that I don't believe it is a
regression but seems to have been around for quite some time.
Subject: [PATCH] Fix imap fetching multiple mailboxes (bug#54158)
* lisp/gnus/mail-source.el (mail-source-fetch-imap): Variables
mailbox-source-string and remove should be reset for each mailbox.
---
lisp/gnus/mail-source.el | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lisp/gnus/mail-source.el b/lisp/gnus/mail-source.el
index 04de70bf0f..320bc9c3b0 100644
--- a/lisp/gnus/mail-source.el
+++ b/lisp/gnus/mail-source.el
@@ -1065,9 +1065,7 @@ mail-source-fetch-imap
(let ((from (format "%s:%s:%s" server user port))
(found 0)
(buf (generate-new-buffer " *imap source*"))
- (mail-source-string (format "imap:%s:%s" server mailbox))
- (imap-shell-program (or (list program) imap-shell-program))
- remove)
+ (imap-shell-program (or (list program) imap-shell-program)))
(if (and (imap-open server port stream authentication buf)
(imap-authenticate
user (or (cdr (assoc from mail-source-password-cache))
@@ -1076,8 +1074,10 @@ mail-source-fetch-imap
(let ((mailbox-list (if (listp mailbox) mailbox (list mailbox))))
(dolist (mailbox mailbox-list)
(when (imap-mailbox-select mailbox nil buf)
- (let ((coding-system-for-write mail-source-imap-file-coding-system)
- str)
+ (let ((coding-system-for-write
+ mail-source-imap-file-coding-system)
+ (mail-source-string (format "imap:%s:%s" server mailbox))
+ str remove)
(message "Fetching from %s..." mailbox)
(with-temp-file mail-source-crash-box
;; Avoid converting 8-bit chars from inserted strings to
--
2.34.1.575.g55b058a8bb
--
Andrew Cohen
Re: Emacs pretest 28.0.92 is out, Eric S Fraga, 2022/03/18