Re: [ELPA] New package: gnus-search-mu

[Jai Flack]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Jai Flack <jflack@disroot.org> writes:
>
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> Jai Flack <jflack@disroot.org> writes:
>>>
>>>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>>>> Hi! Thanks very much for working on this. Wouldn't it make more sense to
>>>>> include this in Emacs proper? Gnus-search is new enough that it doesn't
>>>>> seem useful to let users of prior Emacs versions to install
>>>>> gnus-search-mu from the repos... What do you think?
>>>>
>>>> I'm happy for it to be included in Emacs proper; though possibly as both
>>>> a la modus-themes as it's missed the release window for Emacs 28 (if I
>>>> understand the release cycle correctly).
>>>>
>>>> Shall I convert this to a patch for gnus-search.el?
>>>
>>> Sure! Thanks.
>>>
>>> Otherwise, please make sure that the first line of docstrings are a
>>> complete sentence, and there's no need for a blank line between the
>>> first sentence and whatever comes after.
>>
>> Right.

Were there any docstrings in particular you noticed that didn't make up
a complete sentence? I've updated them to be (roughly) the same as the
notmuch and namazu backends but the first lines already matched.

>>> Out of curiosity, what is `ansi-color-filter-apply' doing there?
>>
>> I think I had trouble with mu giving ANSI escape codes to Emacs, it
>> might no longer be a problem or maybe there is a better solution.
>
> Okay, sounds good! ansi-color is built in so there's no harm in that.

I've changed this to use the --nocolor option for mu.

> I'm assuming you have done copyright assignment. Do you have push
> permissions for ELPA and/or Emacs proper?

Done copyright assignment. Don't have any push permissions.

For the ELPA package is there a good way to signal to users that the
built-in version should be used on a recent-enough Emacs version?

-- 
Thanks,
Jai