Re: master fbf2ed9a64: ipv6 addresses aren't suspicious

[Robert Pluim]

>>>>> On Tue, 29 Mar 2022 11:12:34 -0400 (EDT), Lars Ingebrigtsen 
>>>>> <larsi@gnus.org> said:

    Lars> branch: master
    Lars> commit fbf2ed9a648d9c0f64519900acf1574d0d74692b
    Lars> Author: Lars Ingebrigtsen <larsi@gnus.org>
    Lars> Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Lars>     ipv6 addresses aren't suspicious
    
    Lars>     * lisp/international/textsec.el (textsec--ipvx-address-p): New
    Lars>     function.
    Lars>     (textsec-domain-suspicious-p): Use it to say that ipv6 addresses
    Lars>     aren't suspicious (bug#54624).
    Lars> ---
    Lars>  lisp/international/textsec.el            | 12 ++++++++++++
    Lars>  test/lisp/international/textsec-tests.el | 11 ++++++++++-
    Lars>  2 files changed, 22 insertions(+), 1 deletion(-)

    Lars> +(defun textsec--ipvx-address-p (domain)
    Lars> +  "Return non-nil if DOMAIN is an ipv4 or ipv6 address."
    Lars> +  (or (string-match-p "\\`\\([0-9]\\{1,3\\}\\.?\\)\\{1,4\\}\\'" 
domain)
    Lars> +      (let ((ipv6 "\\([0-9a-f]\\{0,4\\}:?\\)\\{1,8\\}"))
    Lars> +        ;; With brackets.
    Lars> +        (or (string-match-p (format "\\`\\[%s\\]\\'" ipv6) domain)
    Lars> +            ;; Without.
    Lars> +            (string-match-p (format "\\`%s\\'" ipv6) domain)))))
    Lars> +

(textsec--ipvx-address-p ":1") => 0

but ":1" is not a valid IPv4 nor IPv6 address.

Perhaps you could use `network-lookup-address-info' instead.

Robert
--