emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] posix_spawn blocks SIGCHLD in spawned processes


From: Robert Pluim
Subject: Re: [PATCH] posix_spawn blocks SIGCHLD in spawned processes
Date: Mon, 04 Apr 2022 16:13:43 +0200

>>>>> On Fri, 04 Mar 2022 11:07:52 +0100, Robert Pluim <rpluim@gmail.com> said:

>>>>> On Fri, 04 Mar 2022 09:38:25 +0100, Jürgen Hötzel <juergen@hoetzel.info> 
>>>>> said:
    Jürgen> IMO the correct way to fix this issue is to use the oldset passed by
    Jürgen> emacs_spawn (patch enclosed) just like the fork/exec implementation 
does.

    Robert> Sure, that would work as well.

    Jürgen> I guess without a fix many forking commands (that don't examine and
    Jürgen> change mask of blocked signals) will "hang" in Emacs.

    Robert> Not really. Itʼs a code path thatʼs non-default, since
    Robert> process-connection-type defaults to t => use pty's, and the command 
in
    Robert> question has to care about its children.  But it needs to be fixed
    Robert> regardless.

    Robert> I donʼt have a test case, but the patch looks good to me.

Now applied to master as 8103b060d8 in Jürgen's name.

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]