[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Re: Other details about completion.
From: |
Juri Linkov |
Subject: |
Re: [PATCH] Re: Other details about completion. |
Date: |
Mon, 04 Apr 2022 22:45:00 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> May I finally add this patch to master??
I don't know, maybe Philip has no time to review your patch?
> On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote:
>>Hi again...
>>
>>Here I attached a small patch that makes 3 small changes:
>>
>>1) Remove the trailing newline in completions one-column
>>2) Use another condition in next-completion to jump to minibuffer.
>>
>>Normally next-completion with tabs at the end of the buffer needs an
>>extra tab because it goes to the end of the last completion before
>>jumping to the minibuffer or wrap.. That extra tab is because the
>>condition to jump or wrap was eobp/bobp assuming that there is not text
>>unproppertized after the last candidate.
>>
>>3) Remove a comment in switch-to-completions. That comment suggested that
>>the next-completion action must be called inside
>>minibuffer-completion-help but IMO that is not totally correct when
>>completion-auto-select has some of the new values.
>>
>>Please, if anyone could review,correct and push I would be very
>>grateful.
- Other details about completion., Ergus, 2022/04/01
- Re: Other details about completion., Eli Zaretskii, 2022/04/01
- Re: Other details about completion., Juri Linkov, 2022/04/01
- Re: Other details about completion., Ergus, 2022/04/01
- [PATCH] Re: Other details about completion., Ergus, 2022/04/01
- Re: [PATCH] Re: Other details about completion., Ergus, 2022/04/04
- Re: [PATCH] Re: Other details about completion.,
Juri Linkov <=
- Re: [PATCH] Re: Other details about completion., Philip Kaludercic, 2022/04/04
- Re: [PATCH] Re: Other details about completion., Ergus, 2022/04/05
- Re: [PATCH] Re: Other details about completion., Ergus, 2022/04/04
- Re: [PATCH] Re: Other details about completion., Juri Linkov, 2022/04/05
- Re: [PATCH] Re: Other details about completion., Ergus, 2022/04/05
- Re: [PATCH] Re: Other details about completion., Juri Linkov, 2022/04/06
- Re: [PATCH] Re: Other details about completion., Ergus, 2022/04/06
- Re: [PATCH] Re: Other details about completion., Juri Linkov, 2022/04/06
- RE: [External] : Re: [PATCH] Re: Other details about completion., Drew Adams, 2022/04/06
- Re: [External] : Re: [PATCH] Re: Other details about completion., Juri Linkov, 2022/04/06