emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: Other details about completion.


From: Juri Linkov
Subject: Re: [PATCH] Re: Other details about completion.
Date: Wed, 06 Apr 2022 21:34:12 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)

>>Here is the next patch that does this and allows using all arrow keys
>>only when the completions window is visible:
>
> Ok quick check :)
>
> With the new option the behavior gives a much better navigation.
>
> 1) There is still the issue with C-g or ESC canceling everything

Do you mean addition step is needed where first C-g/ESC will clear
the suffix, then another C-g/ESC will exit the minibuffer?

> 2) In tabular navigation the down arrow always goes to the first column
> which is wrong; maybe it should use next-line or line-move instead of
> forward-line?

This is what I tried first, but byte-compiler complained next-line
is only for interactive use.

> 3) It still needs and extra binding to insert and then to another
> execute... RET just removes the highlight and nothing else... which is
> un-intuitive because the candidate in principle is already selected.

Then it should always insert the selected candidate.

> I am not a good lisper, but I think that an approach with a minor mode
> or a transient-map could end up being simpler and more modular without
> adding more complexity in the existing code... WDYT?

A minor mode that adds a hook to minibuffer-setup-hook
that activates another mode with additional keymap?
Looks more complex.  And a transient-map on post-command-hook
is even more complicated.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]