[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 5141234acf: Refactor the webp cache code to allow usage by gi
From: |
Lars Ingebrigtsen |
Subject: |
Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too |
Date: |
Mon, 11 Apr 2022 15:04:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Po Lu <luangruo@yahoo.com> writes:
> The object might be garbage collected, and another one could be consed
> with the same type tag and address as the original.
It seems rather unlikely -- especially since it's also checking that the
index is the expected one.
> So we should probably mark that data upon garbage collection.
For the imagemagick cache, we're just using a cookie, that's basically
what we're doing here, too. Perhaps sxhashing the spec and using that
instead would be fine, but it's slower, and we don't really care that
much about correctness here -- we're just using this to speed things up,
after all.
So I dunno. My only worry was that not gc-protecting it might lead to a
segfault somewhere.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too,
Lars Ingebrigtsen <=
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Stefan Monnier, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Eli Zaretskii, 2022/04/11