emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 18ec3fcce9: Restore pending_signals at a point in the DND eve


From: Stefan Monnier
Subject: Re: master 18ec3fcce9: Restore pending_signals at a point in the DND event loop
Date: Sat, 16 Apr 2022 23:21:25 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

> @@ -9674,7 +9675,12 @@ x_dnd_begin_drag_and_drop (struct frame *f, Time time, 
> Atom xaction,
>                        &next_event, &finish, &hold_quit);
>  #endif
>  #endif
> +      /* The unblock_input below might try to read input, but
> +      XTread_socket does nothing inside a drag-and-drop event
> +      loop, so don't let it clear the pending_signals flag.  */
> +      signals_were_pending = pending_signals;
>        unblock_input ();
> +      pending_signals = signals_were_pending;
>  
>        if (x_dnd_movement_frame)
>       {

This is pretty ugly.
Why is it that it "does nothing"?  Any hope we can move this restoration
of `pending_signals` closer to the code that "does nothing"?


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]