[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master fa52782f5c: Make timer_check even more resilient
From: |
Po Lu |
Subject: |
Re: master fa52782f5c: Make timer_check even more resilient |
Date: |
Fri, 29 Apr 2022 20:40:09 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> + block_input ();
> + turn_on_atimers (false);
>
> /* We use copies of the timers' lists to allow a timer to add itself
> again, without locking up Emacs if the newly added timer is
> @@ -4646,6 +4648,8 @@ timer_check (void)
> else
> idle_timers = Qnil;
>
> + turn_on_atimers (true);
> + unblock_input ();
Does input really have to be blocked around this?
The call to `unblock_input' will end up reading async input, which might
not be safe at that spot. (The X11 drag and drop code used to suffer
from this problem, and debugging the resulting crashes was not easy.)
- Re: master fa52782f5c: Make timer_check even more resilient,
Po Lu <=