emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master b2e6e95581: Only reset buffer-local buffer-stale-function in


From: Eli Zaretskii
Subject: Re: master b2e6e95581: Only reset buffer-local buffer-stale-function in make-indirect-buffer
Date: Mon, 11 Jul 2022 20:20:31 +0300

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 11 Jul 2022 11:59:20 -0400
> 
> > +      if (!NILP (Flocal_variable_p (Qbuffer_stale_function, base_buffer)))
> > +   Fset (Qbuffer_stale_function, Qbuffer_stale__default_function);
> 
> Shouldn't this use `kill-local-variable` instead or something like that?

I'm also not sure it is wise not to use nil here, since
buffer-stale--default-function is only defined when files.el is
loaded, so this could cause trouble during bootstrap (if not now, then
in some distant future).  At least Ffboundp test is in order, I think.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]