[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] externals/csharp-mode 7d7bf8895b 3/3: Merge pull request #264

From: Stefan Monnier
Subject: Re: [elpa] externals/csharp-mode 7d7bf8895b 3/3: Merge pull request #264 from emacs-csharp/feature/non-eask-test
Date: Wed, 17 Aug 2022 07:58:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

> +;; development only packages, not declared as a package-dependency
> +;; FIXME: loading a .el file from `load-path' should not change user's 
> settings
> +;; like that.  It can happen without the user explicitly requesting it!
> +(package-initialize)
> +(add-to-list 'package-archives '("melpa" . 
> "https://stable.melpa.org/packages/";))

Thanks for the FIXME :-)

BTW, the standard way to fix this problem is to wrap that code inside
a function (say `csharp-mode-tests-setup`) and then instead of:

> -     $(EASK) test ert csharp-mode-tests.el
> +     $(EMACS) -Q -batch -L . -l csharp-mode-tests.el -f 
> ert-run-tests-batch-and-exit

you do something like:

        $(EMACS) -Q -batch -L . -l csharp-mode-tests.el \
                 -f csharp-mode-tests-setup             \
                 -f ert-run-tests-batch-and-exit

Tho of course, you can also move some of that code to the new function
so that instead you might end up with something like:

        $(EMACS) -Q -batch -l csharp-mode-tests.el -f csharp-mode-tests-run

-- Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]