[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration
From: |
Po Lu |
Subject: |
Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration |
Date: |
Fri, 19 Aug 2022 19:58:36 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> branch: master
> commit 088171e05316c9188186a731f3c7e68c103c4e0a
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Fix ns-win.el (x-file-dialog) declaration
>
> * lisp/term/ns-win.el (x-file-dialog): Give the function the same
> signature here as other definitions.
> ---
> lisp/term/ns-win.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
> index e26191b33b..56aca2bd83 100644
> --- a/lisp/term/ns-win.el
> +++ b/lisp/term/ns-win.el
> @@ -439,7 +439,8 @@ Lines are highlighted according to `ns-input-line'."
>
> ;;;; File handling.
>
> -(defun x-file-dialog (prompt dir default_filename mustmatch only_dir_p)
> +(defun x-file-dialog (prompt dir &optional default_filename
> + mustmatch only_dir_p)
> "SKIP: real doc in xfns.c."
> (ns-read-file-name prompt dir mustmatch default_filename only_dir_p))
>
I guess it would be good to change the function arguments names too to
avoid the underscores.
- Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration,
Po Lu <=