[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master ee6e4bc525: Update device-specific grab during drag-and-drop
From: |
Eli Zaretskii |
Subject: |
Re: master ee6e4bc525: Update device-specific grab during drag-and-drop |
Date: |
Sun, 21 Aug 2022 16:12:45 +0300 |
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Po Lu <luangruo@yahoo.com>
> Date: Sun, 21 Aug 2022 15:03:10 +0200
>
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
> > Update device-specific grab during drag-and-drop
> >
> > * src/xterm.c (x_detect_focus_change): Fix typo.
> > (handle_one_xevent): Set device if DND is in progress and update
> > device->grab.
>
> This (or something other change in this area) leads to the following
> warnings in an --with-x-toolkit=no build on the current Ubuntu:
>
> xterm.c: In function 'handle_one_xevent':
> xterm.c:21537:40: warning: potential null pointer dereference
> [-Wnull-dereference]
> 21537 | device->grab &= ~(1 << xev->detail);
> | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
> xterm.c:21537:40: warning: potential null pointer dereference
> [-Wnull-dereference]
> 21537 | device->grab &= ~(1 << xev->detail);
> | ^~
I tried to fix this now.