[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 95b1eacd47: Fix handling of UNCs in 'parse-colon-path

From: Ken Brown
Subject: Re: master 95b1eacd47: Fix handling of UNCs in 'parse-colon-path
Date: Wed, 24 Aug 2022 14:34:02 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2

On 8/24/2022 12:20 PM, Eli Zaretskii wrote:
branch: master
commit 95b1eacd4750da7329380aabcb383a8f9d96a59b
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>

     Fix handling of UNCs in 'parse-colon-path
* lisp/files.el (parse-colon-path): Don't remove the second
     leading slash on systems that support UNCs.  (Bug#57353)
* test/lisp/files-tests.el (files-tests-bug-21454): Update
     expected results.
     (files-colon-path): Add a new test pattern.

After this commit I'm getting the following test failure on Cygwin. I don't have time to look into it now, but I can do so in a few days if the fix isn't obvious.

Test files-tests-bug-21454 backtrace:
  signal(ert-test-failed (((should (equal res (parse-colon-path "$FOO"
  ert-fail(((should (equal res (parse-colon-path "$FOO"))) :form (equa
  #f(compiled-function () #<bytecode 0x197d9660f67edbed>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name files-tests-bug-21454 :documentation
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":../../master/test" "-l" "ert" "-l" "lisp/file
Test files-tests-bug-21454 condition:
       (equal res
              (parse-colon-path "$FOO")))
       ("/foo/bar/" "/bar/qux/" "/qux/foo/")
       ("//foo/bar/" "/bar/qux/" "/qux/foo/"))
      :value nil :explanation
      (list-elt 0
                (arrays-of-different-length 9 10 "/foo/bar/" "//foo/bar/" 
first-mismatch-at 1))))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]