Re: Add zuul.el package to ELPA

[Philip Kaludercic]

Niklas Eklund <niklas.eklund@posteo.net> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Niklas Eklund <niklas.eklund@posteo.net> writes:
>>
>>> Niklas Eklund <niklas.eklund@posteo.net> writes:
>>>
>>>> Philip Kaludercic <philipk@posteo.net> writes:
>>>>
>>>>> Niklas Eklund <niklas.eklund@posteo.net> writes:
>>>>>
>>>>>>> I believe if you used compat, you can reduce the minimal version of
>>>>>>> Emacs down to 26.1, and the only hard dependency appears to be
>>>>>>> project.el?
>>>
>>> One other thing I saw that package lint complained about, and that I
>>> couldn't find in the compat package was with-connection-local-variables?
>>>
>>> 486:3: error: You should depend on (emacs "27.1") if you need
>>> `with-connection-local-variables'.
>>>
>>> I see in the manual that it doesn't seem to be supported
>>> https://git.sr.ht/~pkal/compat/tree/master/compat.texi#L1753. So I guess
>>> I can lower it to 27.1 the most, but that would be a good win over 28.1 :)
>>
>> True, that is missing, but reading through the source in files-x.el, it
>> *might* be possible to add that functionality in a backwards
>>  way?  But if not, 27.1 is still a considerable improvement considering
>>  that Debian Stable is currently distributing that version.
>
> Absolutely, a great improvement! :) If that is added in the future that
> would be even better of course, seems like that's the only thing
> blocking the package from supporting 26. 
>
> Once you have released a new version of compat I'll try to depend on
> that. Would this patch be sufficient you think? (given that I update the
> version of compat to the latest)
>
> From a698110e477a1e640b851f912601c67e19bea6b7 Mon Sep 17 00:00:00 2001
> From: Niklas Eklund <niklas.eklund@posteo.net>
> Date: Wed, 31 Aug 2022 13:38:06 +0200
> Subject: [PATCH] Use compat package to support older Emacs version
>
> This patch lowers the required Emacs version from 28.1 to 27.1. This
> is done by using the compat package in combination with an explicit
> dependency to the project package.
> ---
>  zuul.el | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/zuul.el b/zuul.el
> index f2b146c..34d4bf7 100644
> --- a/zuul.el
> +++ b/zuul.el
> @@ -5,7 +5,7 @@
>  ;; Author: Niklas Eklund <niklas.eklund@posteo.net>
>  ;; URL: https://git.sr.ht/~niklaseklund/zuul.el
>  ;; Version: 0.3
> -;; Package-Requires: ((emacs "28.1"))
> +;; Package-Requires: ((emacs "27.1") (compat "2.1.2.2") (project "0.8.1"))
>  ;; Keywords: convenience tools
>  
>  ;; This file is not part of GNU Emacs.
> @@ -41,6 +41,9 @@
>  
>  (require 'ansi-color)
>  (require 'comint)
> +(require 'compat)
> +(require 'compat-27)
> +(require 'compat-28)

These two require statements aren't required, unless you depend on some
function that has been updated between versions (e.g. assoc used to only
take two arguments, and now takes 3, so to avoid overriding the old call
compat provides a prefixed alternative "compat-assoc").

>  (require 'project)
>  (eval-when-compile (require 'rx))
>  (require 'subr-x)
> @@ -770,7 +773,7 @@ Optionally provide extra parameters PARAMS, PARSER, 
> METHOD, BUFFER or HEADERS."
>    "Parse the output of a json build."
>    (let ((build (zuul--request-json-parser)))
>      (string-join
> -     (flatten-list
> +     (flatten-tree
>        (seq-map #'zuul--build-playbook-output build))
>       "\n")))