[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifyi
Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection
Sat, 17 Sep 2022 13:04:38 +0000
Protesilaos Stavrou <email@example.com> writes:
>> From: Philip Kaludercic <firstname.lastname@example.org>
>> Date: Sat, 17 Sep 2022 10:40:32 +0000
>> [... 21 lines elided]
>>> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
>>> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
>>> +;; This duplication seems unnecessary.
>>> (defconst ef-themes-collection
>> Is there any reason you couldn't just replace the definition with
>> (seq-union ef-themes-light-themes ef-themes-dark-themes)
> You mean to include that in the relevant functions and remove the
> 'ef-themes-collection' altogether?
I was thinking of replacing the
with the `seq-union' call from above.
> I was thinking that having a
> standalone variable is easier for documentation purposes. Same for
> Though yes, your code does what I want.