Re: feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available.

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: Vibhav Pant <vibhavp@gmail.com>
>> Date: Wed, 28 Sep 2022 08:22:36 +0800
>> 
>> BTW, I don't see any code that loads this function dynamically on MS
>> Windows.  Isn't that needed?
>
> They were present in the patch that was posted.
>
> FWIW, I'd like to see some rationale for these changes.  Perhaps
> libgccjit experts would see it immediately without any explanations,
> but I'm not such an expert.  TIA.

I think having explicit casts expressed to the compiler (instead of
working it around with unions as we do now) could enable the compiler
for better optimizations or maybe even some compile time gain.  Before
libgccjit did not allow for expressing it, so it's good that now we take
advantage of it when available.

Best Regards

  Andrea