emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expre


From: Robert Pluim
Subject: Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.
Date: Fri, 14 Oct 2022 15:11:09 +0200

>>>>> On Fri, 14 Oct 2022 18:28:39 +0530, Vibhav Pant <vibhavp@gmail.com> said:

    Vibhav> On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote:
    >> This is not how we write commit messages; it should be:
    >> 
    >> * src/comp.c: Add declarations for creating
    >> constructor/initializer expressions when supported.
    >> (emit_coerce): Use a struct constructor expression to create a
    >> Lisp_Object value instead of creating a new local variable.
    >> (emit_limple_call_ref): Emit a single constructor expression for
    >> initializing tmp_arr.
    >> 
    >> Keep in mind that the commit message must also be filled to 64
    >> columns.

    Vibhav> Ah, knew something about it was off. Thanks :)

See also "** Generating ChangeLog entries" in CONTRIBUTE, it describes
Emacs facilities to help here.

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]