Re: [PATCH] Add user content APIs for WebKit Xwidgets

[Po Lu]

Qiantan Hong <qthong@stanford.edu> writes:

> Some existing code in xwidget.c use this naming as well.
> Should I make a separate patch to fix those?

No, I'd rather avoid extraneous style changes to existing contents of
the file.  At the very least it makes vc-annotate a pain.

> Should I also include the fix to some capitalization error
> and the runtime symbol usage in that same patch?

BTW, there are many other problems with your patch, aside from
capitalization and interning symbols with a static string.  Please read
through the entirety of my reply.

> How do I mark it?

I suggest linking each callback data struct into a list, each element of
which is then marked in a "mark_xwidget" function that should be called
by garbage_collect in alloc.c.

> I’m imitating the usage pattern of what is already in nsxwidget.m.
> I think if I’m leaking memory then the current code must also have been
> (which could be the case)...

I guess that should be fixed.

Thanks.