[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Some issues with the tree-sitter branch
From: |
Yuan Fu |
Subject: |
Re: Some issues with the tree-sitter branch |
Date: |
Mon, 17 Oct 2022 17:15:17 -0700 |
> On Oct 17, 2022, at 3:14 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Mon, 17 Oct 2022 02:12:13 -0700
>> Cc: emacs-devel@gnu.org
>>
>>> That sounds fine to me, but I think we also should do something when
>>> some value that can be larger than UINT_MAX is passed to tree-sitter
>>> functions, because doing so might cause tree-sitter do something for a
>>> completely unrelated portion of the buffer. At the very least add
>>> eassert there, so that at least a build with --enable-checking will
>>> detect such cases.
>>
>> IIUC you don’t want to hide and delay the error, right? That makes sense. I
>> can add assertions, those assertions shouldn’t interfere with normal usage.
>
> Yes, please.
Now done.
Re: Some issues with the tree-sitter branch, Yuan Fu, 2022/10/17
Re: Some issues with the tree-sitter branch, Yuan Fu, 2022/10/17