emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] Allow applying filters to summary consecutively


From: Robert Pluim
Subject: Re: [PATCH v3] Allow applying filters to summary consecutively
Date: Thu, 20 Oct 2022 18:02:28 +0200

>>>>> On Thu, 20 Oct 2022 17:45:56 +0200, Andrea Monaco 
>>>>> <andrea.monaco@autistici.org> said:

    >> Iʼd call it `rmail-summary-stack-filters' and say

    Andrea> The metaphor of a stack is not perfect, as we don't have any "pop", 
that
    Andrea> is there's no command to cancel the last filter.

Ah. How are people expected to get back to showing all messages?

    >> I donʼt remember the details of rmailʼs summary line format, but I
    >> think youʼd be better served with (thing-at-point 'number)

    Andrea> There is some padding with whitespace at the beginning of each 
line, so
    Andrea> you'd still need a jump command.

Well, you could search forward from bol for a digit easily enough.

    >> I think you have this same lambda about 4 times in the code, perhaps
    >> `defun' it (using "rmail-summary--" as a prefix to indicate that
    >> itʼs intended for internal usage)

    Andrea> The five lambdas I added (one for each rmail-summary-by-* command) 
are
    Andrea> similar but not identical.  Maybe I could write a general function, 
but
    Andrea> I find it too much of a hassle for a little line saving.

OK

    Andrea> I agree on the other objections.

Suggestions, not objections. Nothing Iʼve said stops the changes from
going in.

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]