[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: feature/tree-sitter 88d54756d4 2/2: Check for outdated tree-sitter n
Re: feature/tree-sitter 88d54756d4 2/2: Check for outdated tree-sitter node when printing
Thu, 03 Nov 2022 16:09:26 +0800
Gnus/5.13 (Gnus v5.13)
Yuan Fu <email@example.com> writes:
> Cool, thanks. I’ll fix them.
> Ah yes, sorry. I though you are going to change your patch and forgot
> to follow up. Everything indeed works, except for the following
> - return Fmapconcat (intern_c_string ("treesit-pattern-expand"),
> - query, build_pure_c_string (" "));
> + return Fmapconcat (Qtreesit_pattern_expand,
> Which breaks a test. Why remove the space? Tree-sitter probably can
> parse it fine without the spaces, but the result is also viewed by
> users in some cases, where spaces are much appreciated.
That was a typo; I just tried to get rid of the extra call to
So if you're fine with the patch (once I fix the typos), I'll install
it. Is that okay?