[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Matching regex case-sensitively in C strings?

From: Eli Zaretskii
Subject: Re: Matching regex case-sensitively in C strings?
Date: Thu, 10 Nov 2022 13:18:56 +0200

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Thu, 10 Nov 2022 10:52:40 +0100
> Cc: casouri@gmail.com, emacs-devel@gnu.org
> 9 nov. 2022 kl. 14.06 skrev Eli Zaretskii <eliz@gnu.org>:
> >> You are right to worry about it, but there is actually no need for
> >> concern here: it's a tail call (and the extra argument is last) so
> >> it should compile to an unconditional jump (and setting a register).
> > 
> > That's not what I see here, even with -O2.
> Trying to read your mind, are you using 32-bit x86? Even that shouldn't be 
> disastrous; it's just some stack manipulation. Hardly noticeable given that 
> it's a regexp match that comes next.

I agree that the effect is probably minuscule, but it's still there.
And on some architectures it could be more than that.

Why not have two separate functions for these two jobs?  The code is
short, and some duplication is not an issue in this case.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]